cmov: add proptests #1295
Merged
cmov: add proptests #1295
+347
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
That's no good. Seems like |
tarcieri
force-pushed
the
cmov/proptests
branch
from
e041940 to
318b614
Compare
tarcieri
added a commit
that referenced
this pull request
Dec 28, 2025
Trying to catch the same bug from #1295 with the existing test suite
Tests the implementation against random cases to ensure correctness
tarcieri
force-pushed
the
cmov/proptests
branch
from
318b614 to
12cfa82
Compare
tarcieri
commented
Dec 28, 2025
Comment on lines
+1
to
+2
| // TODO(tarcieri): known to be broken on PPC32. See RustCrypto/utils#1298 | ||
| #![cfg(not(target_arch = "powerpc"))] |
Member
Author
There was a problem hiding this comment.
I did this for now to get the tests to pass, but a compile_error! might be the safest stopgap until the bug is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the implementation against random cases to ensure correctness