Skip to content

Conversation

@newpavlov
Copy link
Member

No description provided.

@newpavlov newpavlov requested a review from tarcieri December 20, 2025 01:43
@newpavlov
Copy link
Member Author

newpavlov commented Dec 20, 2025

@tarcieri
Note that the problematic test does not trigger our CI for some reason. We may need to add --all-targets for this.

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I never saw this at all... is it nightly-only or something?

@tarcieri tarcieri merged commit 5f0b306 into master Dec 20, 2025
11 checks passed
@tarcieri tarcieri deleted the ctutils/fix_bool_assert_comparison branch December 20, 2025 01:46
@newpavlov
Copy link
Member Author

newpavlov commented Dec 20, 2025

It was added in 1.53: https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison But maybe it was not enabled by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants