[WIP] aead: add PrefixNonceAead#2418
Draft
tarcieri wants to merge 1 commit into
Draft
Conversation
9 tasks
27d714b to
4995e9a
Compare
Member
Author
|
I suppose this is always assuming a postfix nonce, I will need to further compose it to abstract over prefix vs postfix nonces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt at #1666 (see also #1818).
Where #1818 tried to add some additional trait methods, this instead opts for a generic newtype which provides type safety around the use of prefix messages (i.e. avoids confusion around accidentally mixing up prefixed and non-prefixed messages by calling the wrong methods) and in general keeps the method space unambiguous so we don't need to worry about qualifying every method name with something to indicate it's working on nonce-prefixed messages.
TODO: tests, docs, but I'm posting this early to get feedback on the general direction