scrypt: add MCF support #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
scrypt/mcf-support
branch
3 times, most recently
from
1a1ba45 to
2e1a918
Compare
Member
Author
|
In case anyone is curious what the problem was with passing the test vectors: like SHA-crypt, the MCF implementation for scrypt passes the Base64 encoded salt to the underlying algorithm, rather than first Base64 decoding it |
tarcieri
force-pushed
the
scrypt/mcf-support
branch
from
2e1a918 to
ab176b6
Compare
Information about the scrypt MCF format comes largely from libxcrypt: https://github.com/besser82/libxcrypt/blob/a74a677/lib/crypt-scrypt.c The format is somewhat like yescrypt in that it uses a special binary encoding of the parameters which is then serialized as little endian crypt-like Base64 (i.e. `./0123456789ABC..XYZZabc..xyz`). However, scrypt doesn't place the parameters in their own `$`-delimited field like yescrypt, but instead concatenates them to the salt and shoves the combined params + salt into a single `$`-delimited field. Also, where yescrypt uses a variable-width integer encoding, scrypt uses a fixed-width encoding.
tarcieri
force-pushed
the
scrypt/mcf-support
branch
from
ab176b6 to
636c81a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: not yet passing test vectorsInformation about the scrypt MCF format comes largely from libxcrypt:
https://github.com/besser82/libxcrypt/blob/a74a677/lib/crypt-scrypt.c
The format is somewhat like yescrypt in that it uses a special binary encoding of the parameters which is then serialized as little endian crypt-like Base64 (i.e.
./0123456789ABC..XYZZabc..xyz).However, scrypt doesn't place the parameters in their own
$-delimited field like yescrypt, but instead concatenates them to the salt and shoves the combined params + salt into a single$-delimited field.Also, where yescrypt uses a variable-width integer encoding, scrypt uses a fixed-width encoding.