Reapply "BREAKING: Make random_mod platform-independent" #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts 5784b13, reapplying 62b90b8. See also: RustCrypto#1018 (comment) It turns out that the previous approach ran afoul of a likely LLVM (or possibly rustc) bug. This time, I tried removing `random_mod_core` entirely and instead writing `random_mod` and `try_random_mod` as rejection loops over `random_bits` and `try_random_bits`. Somehow, this does not (seem to) run afoul of the bug.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
- Coverage 79.86% 79.85% -0.02%
==========================================
Files 163 163
Lines 17737 17736 -1
==========================================
- Hits 14166 14163 -3
- Misses 3571 3573 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@tarcieri WDYT? I could go either way on this personally; it does seem a bit of a shame to lose |
Contributor
Author
|
(fyi #1009) I don't think I like this approach. With that bug lurking and the BoxedUint loop untested, this could still hang in some cases; I don't know why it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1017, reapplying #1010. See also: #1018 (comment).
It turns out that the previous approach ran afoul of a likely LLVM (or possibly rustc) bug.
This time, I tried removing
random_mod_coreentirely and instead writingrandom_modandtry_random_modas rejection loops overrandom_bitsandtry_random_bits. It is a little unfortunate that we write the rejection loop three times, but somehow, this does not (seem to) run afoul of the bug.