ssh-key: simplified ECDSA private key decoding logic #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ssh-key/simplify-ecdsa-private-key-decoding
branch
2 times, most recently
from
3139b99 to
d465f08
Compare
Member
Author
|
cc @zaczkows |
tarcieri
force-pushed
the
ssh-key/simplify-ecdsa-private-key-decoding
branch
from
d465f08 to
ee5af6f
Compare
Followup to #351 Also includes a fix and test to ensure that short keys zero-pad MSB rather than LSB, since they're encoded as big endian.
tarcieri
force-pushed
the
ssh-key/simplify-ecdsa-private-key-decoding
branch
from
ee5af6f to
dd30015
Compare
tarcieri
commented
Apr 19, 2025
Comment on lines
+744
to
+750
| let keypair_data = key.key_data().ecdsa().unwrap(); | ||
| assert_eq!( | ||
| keypair_data.private_key_bytes(), | ||
| hex!( | ||
| "000f65a3a88314a64da9c750b55639b5e532dae02163c8049b8b5a7085a9e24f8f2cfbb3ee5edf2def95f49819e83df6ce8695b24a207093972b0e5f745d03ed50d4" | ||
| ) | ||
| ); |
Member
Author
There was a problem hiding this comment.
@zaczkows it would be good if you could confirm this is the expected private key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #351
Also includes a fix and test to ensure that short keys zero-pad MSB rather than LSB, since they're encoded as big endian.