ssh-encoding: remove length prefix from [u8; N] encoding
#342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type `[u8; N]` maps naturally to SSH's `byte[n]` type, which has no length prefix because `n` is known a priori. In cases where `[u8; N]` is being used to store an SSH `string`, such as Ed25519 public keys, it first needs to be converted to `[u8]` (which maps to `string`) using `as_slice()`
tsurdevson
added a commit
to tsurdevson/SSH
that referenced
this pull request
Mar 26, 2025
Followup to RustCrypto#342, which only updated the `encode` method. This aligns the `encoded_len` method with that change.
tarcieri
pushed a commit
that referenced
this pull request
Mar 26, 2025
Followup to #342, which only updated the `encode` method. This aligns the `encoded_len` method with that change.
tarcieri
deleted the
ssh-encoding/remove-length-prefix-from-byte-array-encoding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
[u8; N]maps naturally to SSH'sbyte[n]type, which has no length prefix becausenis known a priori.In cases where
[u8; N]is being used to store an SSHstring, such as Ed25519 public keys, it first needs to be converted to[u8](which maps tostring) usingas_slice()