Skip to content

fix(android): showing seemingly duplicate devices naming #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
setoelkahfi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(android): showing seemingly duplicate devices naming #1109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02fbdbf
Improve device naming and filter unsupported configs
setoelkahfi Feb 20, 2026
6d2d641
Merge branch 'master' into fix/android-list-unique-devices
setoelkahfi Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/host/aaudio/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,13 @@ impl DeviceTrait for Device {
match &self.0 {
None => Ok(DeviceDescriptionBuilder::new("Default Device".to_string()).build()),
Some(info) => {
let mut builder = DeviceDescriptionBuilder::new(info.product_name.clone())
.device_type(info.device_type.into())
let device_type: DeviceType = info.device_type.into();
let name = match device_type {
DeviceType::Unknown => info.product_name.clone(),
_ => format!("{} ({})", info.product_name, device_type),
};
let mut builder = DeviceDescriptionBuilder::new(name)
.device_type(device_type)
.interface_type(info.device_type.into())
.direction(info.direction);

Expand All @@ -432,7 +437,12 @@ impl DeviceTrait for Device {
&self,
) -> Result<Self::SupportedInputConfigs, SupportedStreamConfigsError> {
let configs = if let Some(info) = &self.0 {
device_supported_configs(info)
// Output-only devices do not support input
if matches!(info.direction, DeviceDirection::Output) {
Vec::new().into_iter()
} else {
device_supported_configs(info)
}
} else {
default_supported_configs()
};
Expand All @@ -443,7 +453,12 @@ impl DeviceTrait for Device {
&self,
) -> Result<Self::SupportedOutputConfigs, SupportedStreamConfigsError> {
let configs = if let Some(info) = &self.0 {
device_supported_configs(info)
// Input-only devices do not support output
if matches!(info.direction, DeviceDirection::Input) {
Vec::new().into_iter()
} else {
device_supported_configs(info)
}
} else {
default_supported_configs()
};
Expand Down