Fix aaudio device name in device.description().name()#1103
Draft
SuperKenVery wants to merge 1 commit intoRustAudio:masterfrom
Draft
Fix aaudio device name in device.description().name()#1103SuperKenVery wants to merge 1 commit intoRustAudio:masterfrom
device.description().name()#1103SuperKenVery wants to merge 1 commit intoRustAudio:masterfrom
Conversation
d0d6635 to
400cfdd
Compare
Member
|
I'm not super-clear on the intent, can you elaborate? It seems that currently returning |
Contributor
Author
|
In #965, the name is changed to product name and device type, on android. Product name is always the device model. You may see the code diff, it's a one line change, and the implementation of name is a few lines above. |
Member
|
If I understand correctly, you are saying that you prefer the behavior of #965? Because I found it weird that a "name" includes a device type and an address. |
Contributor
Author
|
I didn't see this before working on fixing #969 I have my own patch locally. What's the status here? |
Contributor
Author
|
@setoelkahfi seems we are doing the same thing, with a little bit different implementation details 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#965 fixed this for
device.name(), which is now a deprecated method. I let.description().name()return the same name.