Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this line when even just importing cpal types while using wasm-bindgen (for either Wasm backend) wasm-bindgen would fail with this cryptic error:
thread 'main' (37303789) panicked at /Users/ian/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wasm-bindgen-cli-support-0.2.106/src/descriptor.rs:200:15: index out of bounds: the len is 0 but the index is 0This change fixes that break and both Wasm backends should work correctly again.
The above break went in before the latest Cpal release, so theoretically anyone using Cpal on Wasm who updates to the latest release will hit the above error. It may be worthwhile to yank the previous release because it's a subtle and difficult error to track down.
It seems like
wasm-bindgencould also do better here to surface a more meaningful error, and it may be worthwhile for cpal to consider running wasm-bindgen in the CI just to make sure it works.