Skip to content

Conversation

@udaykiriti
Copy link

No description provided.

@udaykiriti udaykiriti changed the title refactor: improve code quality with constants and cleaner init Made changes in code small minor changes Dec 10, 2025
@udaykiriti udaykiriti changed the title Made changes in code small minor changes Made changes in code small minor changes && added some commands in readme file Dec 10, 2025
@udaykiriti udaykiriti closed this Dec 26, 2025
@ojeda
Copy link
Member

ojeda commented Dec 29, 2025

Thanks for the PR -- not sure why this was closed, but I took a quick look and perhaps it was because it was incomplete (Makefile changes are missing)?

Also, I don't think the template should have LLVM=1 as the default or things like M= and -C handled automatically. The commands are intentionally kept close to what you do in-tree. The idea of this repository is to have a basic template that showcases that there is little difference w.r.t. a C out-of-tree module (apart from the requirements as explained in the README), rather than to build a convenient, full-fledged framework here over time. For that, there are better templates/projects/approaches out there.

Finally, for future patches/PRs you may send, I would recommend describing your changes, splitting them, etc. I would recommend reading, for instance, https://docs.kernel.org/process/submitting-patches.html. Those are good practices, even outside the Linux kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants