Conversation
BennoLossin
force-pushed
the
dev/fix-clippy
branch
from
c93596a to
8754f74
Compare
`clippy` has changed behavior in [1] (Rust 1.95) where it no longer warns about the `let_and_return` lint when a comment is placed between the let binding and the return expression. Nightly thus fails to build, because the expectation is no longer fulfilled. Thus replace the expectation with an `allow`. Link: rust-lang/rust-clippy#16461 [1] Signed-off-by: Benno Lossin <lossin@kernel.org>
BennoLossin
force-pushed
the
dev/fix-clippy
branch
from
8754f74 to
3fe4cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clippyhas changed behavior in [1] where it no longer warns about thelet_and_returnlint when a comment is placed between the let binding and the return expression. Thus remove the expectation.Link: rust-lang/rust-clippy#16461 [1]
I'll still have to check if we only support the latest clippy version in the kernel.
Edit: we have to support older versions as well, so I changed it to an allow.