Merged
Conversation
dc7ae2d to
6bce6fe
Compare
Member
Author
|
just discovered there's a dry-run, want to add that since this repo is particularly sensitive to packaging due to selectively including cpp and header files |
f65b94d to
67b814d
Compare
a7dd244 to
3d9975c
Compare
Member
Author
|
I don't know why in the last commit the first release-plz-dry-run failed, but the second one succeeded. I'll call it a fluke for now and we'll see if it shows up again. @LegNeato ready for review, I'd like to publish this crate to see if everything works before copying this to rust-gpu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for porting this to rust-gpu:
spirv-tools-sysand leavespirv-toolsalone, seemingly wanting to release only that one since it's the only one with changes. However, it bumped the version in the workspace, also bumping the version ofspirv-toolswithout touching the changelog. During development, something made it suddenly start updating the changelog ofspirv-toolsas well, I can't exactly pinpoint what. This could cause issues withrustc_codegen_spirvandspirv-stdalways needing to be the same version.