rust: Explicitly instantiate FFIVec<Piece> template#4446
rust: Explicitly instantiate FFIVec<Piece> template#4446powerboat9 merged 1 commit intoRust-GCC:masterfrom
Conversation
|
It looks like you need to add a change log to your commit. Check out the change log section of https://gcc.gnu.org/contribute.html#patches (be discerning about the other sections, since the rust front end mostly uses github instead of email to coordinate patches) |
|
hey @powerboat9 , I have added the changelog but still github check is not passing, can you please tell me what i'm doing wrong? |
|
Oh, you're supposed to include the change log entry in your commit message, the |
hriztam
force-pushed
the
fix/clang-warning
branch
from
ca67f6f to
bf84f39
Compare
|
Could you add a comment about this being required to stop a clang warning? |
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
I think the fix is good, but your commits need to be squashed together in one commit. You also don't need to repeat your email address multiple times, just once at the end for the Signed-off-by line. Take a look at how other commits are formatted in our logs
| std::make_shared<decltype (data)::element_type> (std::move (str), | ||
| std::move (pieces))) | ||
| std::make_shared<decltype (data)::element_type> (std::move (str), | ||
| std::move (pieces))) |
There was a problem hiding this comment.
This change is probably what makes the clang-format check fails, and is unneeded - please remove it :)
hriztam
force-pushed
the
fix/clang-warning
branch
from
1a8dcb0 to
174e05f
Compare
|
hello @CohenArthur , apologies for not being active for this long, I was busy with some personal issues but now I'm well and I wanna contribute to rust-gcc with the best of my abilities, I have squished the commits like you asked, let me know if you need any changes |
|
Looks like you've just got to adjust the code formatting and remove the extra from the commit message. |
gcc/rust/ChangeLog: * ast/rust-fmt.h: Explicitly instantiate FFIVec<Piece>. Signed-off-by: Hritam Shrivastava <hritamstark05@gmail.com>
hriztam
force-pushed
the
fix/clang-warning
branch
from
174e05f to
7a9c40c
Compare
|
done @powerboat9 |
3 participants
Address #4441
rust: Explicitly instantiate FFIVec for C-linkage
Clang warns about returning an incomplete templated type from extern "C"
functions. Explicitly instantiating FFIVec before the declarations
makes the type complete at the declaration site and silences the warning
without changing behavior.
Signed-off-by: Hritam Shrivastava hritamstark05@gmail.com