replacing deprecated Nan:MakeCallback with Nan::AsyncResource#31
Open
artynet wants to merge 1 commit intoRush:masterfrom
Open
replacing deprecated Nan:MakeCallback with Nan::AsyncResource#31artynet wants to merge 1 commit intoRush:masterfrom
artynet wants to merge 1 commit intoRush:masterfrom
Conversation
Rush
reviewed
Oct 30, 2019
| } | ||
|
|
||
| Nan::MakeCallback(Nan::GetCurrentContext()->Global(), Nan::New(m->callback), 1, args); | ||
| Nan::AsyncResource *asyncResource = new Nan::AsyncResource("callback"); |
Owner
There was a problem hiding this comment.
Sounds like a clean change ... but my question is what is calling delete on asyncResource ?
Owner
There was a problem hiding this comment.
Without delete we might have a memory leak.
Contributor
Author
There was a problem hiding this comment.
Are you 100% sure that the new NAN APIs and node 12 won't take care of it ? do you have some sort of setup to run some tests....or at least tell me how to do it ?
Owner
There was a problem hiding this comment.
You could test it by running the code in debug mode and with valgrind to check for memory leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replacement is safe and it is strongly advised according the new https://github.com/nodejs/nan APIs
https://github.com/nodejs/nan/blob/master/doc/node_misc.md#api_nan_asyncresource
@WeiAnAn was definitely right in making this crucial modification