Skip to content

Update CI#38

Merged
tarcieri merged 4 commits intoRubyCrypto:mainfrom
n-rodriguez:wip/ci
Jan 21, 2025
Merged

Update CI#38
tarcieri merged 4 commits intoRubyCrypto:mainfrom
n-rodriguez:wip/ci

Conversation

@n-rodriguez
Copy link
Contributor

Thank you!

@tarcieri tarcieri merged commit 0f3bb43 into RubyCrypto:main Jan 21, 2025
@n-rodriguez
Copy link
Contributor Author

Thank you!

@n-rodriguez n-rodriguez deleted the wip/ci branch January 21, 2025 19:01
@tarcieri
Copy link
Contributor

@n-rodriguez it looks like RuboCop is (unrelatedly) failing, FWIW

@n-rodriguez
Copy link
Contributor Author

@tarcieri yes, it's due to Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.

I don't know what you want to do with that :) (you must enable MFA on Rubygems first)

@tarcieri
Copy link
Contributor

tarcieri commented Jan 21, 2025

It can be added to the code first, right? Nothing is actually linting it against RubyGems?

Or you can shut off that cop

@n-rodriguez
Copy link
Contributor Author

It can be added to the code first, right? Nothing is actually linting it against RubyGems?

Yes but :

The version being released with rubygems_mfa_required set and all the following versions will require you to have MFA enabled.

See: https://guides.rubygems.org/mfa-requirement-opt-in/

Or you can shut off that cop

I can do that

@n-rodriguez
Copy link
Contributor Author

@tarcieri Fixed in #39

@tarcieri tarcieri mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments