fix: prevent queued messages from auto-approving unapproved commands

[roomote-v0]

Related GitHub Issue

Closes: #12302

Description

This PR attempts to address Issue #12302. Feedback and guidance are welcome.

Root cause: In Task.ask(), when a queued message is drained during a command, tool, or use_mcp_server ask, the code unconditionally sent "yesButtonClicked", which approved the pending command regardless of auto-approval settings. This meant any queued message would silently approve commands the user never explicitly approved.

Fix: Changed both queued-message drain locations (the immediate drain at line ~1437 and the pWaitFor poll at line ~1462) to send "messageResponse" instead of "yesButtonClicked" for tool/command/mcp asks. This matches the existing behavior when a user types a reply without clicking the Approve button -- the command gets rejected and the message text is forwarded as a regular message.

Commands that were already auto-approved (via checkAutoApproval returning decision: "approve") are resolved before reaching the drain code, so they are unaffected by this change.

Test Procedure

• Added 3 new test cases to src/core/task/__tests__/ask-queued-message-drain.spec.ts covering command, tool, and use_mcp_server ask types
• All 3 new tests verify the response is "messageResponse" (rejected) rather than "yesButtonClicked" (approved)
• Existing tests for followup and command_output asks continue to pass
• All 5 tests pass: cd src && npx vitest run core/task/__tests__/ask-queued-message-drain.spec.ts

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes.
• Documentation Impact: No documentation updates are required.
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

• No documentation updates are required.

Additional Notes

Two files changed:

• src/core/task/Task.ts -- changed "yesButtonClicked" to "messageResponse" in two locations within the queued message drain logic
• src/core/task/__tests__/ask-queued-message-drain.spec.ts -- added 3 new tests for command/tool/mcp ask types

Interactively review PR in Roo Code Cloud