feat: add Bedrock models minimax.minimax-m2.5 and moonshotai.kimi-k2.5#12299
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
feat: add Bedrock models minimax.minimax-m2.5 and moonshotai.kimi-k2.5#12299roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12298
Description
This PR attempts to address Issue #12298. It adds two missing Bedrock model definitions to
packages/types/src/providers/bedrock.ts:moonshotai.kimi-k2.5- Kimi K2.5 by Moonshot AI, placed after the existingmoonshot.kimi-k2-thinkingentryminimax.minimax-m2.5- MiniMax M2.5, placed after the existingminimax.minimax-m2entryThe model IDs match those confirmed by the reporter from their AWS Bedrock console. Model specs (context window, max tokens, pricing) are based on the existing similar models in the codebase. Pricing may need to be verified against the latest AWS Bedrock pricing page.
Feedback and guidance are welcome.
Test Procedure
cd src && npx vitest run api/providers/__tests__/bedrock.spec.ts)Pre-Submission Checklist
Documentation Updates
Additional Notes
The pricing for both new models is based on the existing similar models (
moonshot.kimi-k2-thinkingandminimax.minimax-m2). If AWS has published different pricing for the m2.5/k2.5 variants, those values should be updated accordingly.Interactively review PR in Roo Code Cloud