Skip to content

feat: add red styling to denied commands in Auto Approve settings#12294

Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
feature/denied-commands-red-styling
Draft

feat: add red styling to denied commands in Auto Approve settings#12294
roomote-v0[bot] wants to merge 1 commit intomainfrom
feature/denied-commands-red-styling

Conversation

@roomote-v0
Copy link
Copy Markdown
Contributor

@roomote-v0 roomote-v0 Bot commented May 8, 2026

Related GitHub Issue

Closes: #12292

Description

This PR attempts to address a suggestion from Issue #12292 by @PlanBernhard to visually distinguish denied commands with red font color in the Auto Approve settings UI.

Changes:

  • Denied command tags in the settings now display with red text (text-red-500) and a subtle red background tint (bg-red-500/20), with a darker hover state (hover:bg-red-500/30)
  • The X (remove) icon on denied command tags also uses red coloring for consistency
  • This matches the existing red styling pattern already used in CommandPatternSelector for denied commands in the chat view

Feedback and guidance are welcome.

Test Procedure

  • Added 2 new tests in SettingsView.spec.tsx:
    • "renders denied commands with red styling": verifies the denied command button has bg-red-500/20 and text-red-500 classes
    • "adds and removes denied commands": verifies add/remove functionality and VSCode messaging for denied commands
  • All 18 tests in SettingsView.spec.tsx pass
  • All 39 tests in CommandExecution.spec.tsx and CommandPatternSelector.spec.tsx pass
  • Linting and type checking pass across all packages

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue
  • Scope: Changes are focused on denied commands red styling
  • Self-Review: I have performed a thorough self-review of my code
  • Testing: New tests have been added to cover the styling changes
  • Documentation Impact: No documentation updates required
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines

Documentation Updates

  • No documentation updates are required.

Additional Notes

The styling uses Tailwind CSS classes consistent with the project guidelines and matches the red styling pattern already established in CommandPatternSelector.tsx (line 160).

Interactively review PR in Roo Code Cloud

Denied command tags in the Auto Approve settings now use red font
color and a subtle red background tint (bg-red-500/20 text-red-500)
to visually distinguish them from allowed commands. This matches the
existing red styling pattern used in CommandPatternSelector.

Addresses feedback from Issue #12292.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [CRITICAL] Auto Approve: Denied commands did not work

1 participant