Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/types/src/providers/zai.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export const mainlandZAiModels = {
},
} as const satisfies Record<string, ModelInfo>

export const ZAI_DEFAULT_TEMPERATURE = 0.6
export const ZAI_DEFAULT_TEMPERATURE = 1

export const zaiApiLineConfigs = {
international_coding: {
Expand Down
1 change: 1 addition & 0 deletions src/api/providers/__tests__/zai.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ describe("ZAiHandler", () => {
model: modelId,
max_tokens: expectedMaxTokens,
temperature: ZAI_DEFAULT_TEMPERATURE,
top_p: 0.95,
messages: expect.arrayContaining([{ role: "system", content: systemPrompt }]),
stream: true,
stream_options: { include_usage: true },
Expand Down
47 changes: 44 additions & 3 deletions src/api/providers/zai.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class ZAiHandler extends BaseOpenAiCompatibleProvider<string> {
}

/**
* Override createStream to handle GLM-4.7's thinking mode.
* Override createStream to handle GLM-4.7's thinking mode and add top_p parameter.
* GLM-4.7 has thinking enabled by default in the API, so we need to
* explicitly send { type: "disabled" } when the user turns off reasoning.
*/
Expand All @@ -64,8 +64,48 @@ export class ZAiHandler extends BaseOpenAiCompatibleProvider<string> {
return this.createStreamWithThinking(systemPrompt, messages, metadata, useReasoning)
}

// For non-thinking models, use the default behavior
return super.createStream(systemPrompt, messages, metadata, requestOptions)
// For non-thinking models, use the default behavior with added top_p
return this.createStreamWithTopP(systemPrompt, messages, metadata, requestOptions)
}

/**
* Creates a stream with top_p parameter for non-thinking models
*/
private createStreamWithTopP(
systemPrompt: string,
messages: Anthropic.Messages.MessageParam[],
metadata?: ApiHandlerCreateMessageMetadata,
requestOptions?: OpenAI.RequestOptions,
) {
const { id: model, info } = this.getModel()

const max_tokens =
getModelMaxOutputTokens({
modelId: model,
model: info,
settings: this.options,
format: "openai",
}) ?? undefined

const temperature = this.options.modelTemperature ?? info.defaultTemperature ?? this.defaultTemperature

const params: OpenAI.Chat.ChatCompletionCreateParamsStreaming = {
model,
max_tokens,
temperature,
top_p: 0.95,
messages: [
{ role: "system", content: systemPrompt },
...convertToZAiFormat(messages, { mergeToolResultText: true }),
],
stream: true,
stream_options: { include_usage: true },
tools: this.convertToolsForOpenAI(metadata?.tools),
tool_choice: metadata?.tool_choice,
parallel_tool_calls: metadata?.parallelToolCalls ?? false,
}

return this.client.chat.completions.create(params, requestOptions)
}

/**
Expand Down Expand Up @@ -96,6 +136,7 @@ export class ZAiHandler extends BaseOpenAiCompatibleProvider<string> {
model,
max_tokens,
temperature,
top_p: 0.95,
messages: [{ role: "system", content: systemPrompt }, ...convertedMessages],
stream: true,
stream_options: { include_usage: true },
Expand Down
Loading