-
Notifications
You must be signed in to change notification settings - Fork 2.8k
ux: Improve subtask visibility and navigation in history and chat views #10864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Review: Approved ✅This PR implements excellent improvements to subtask visibility and navigation across history and chat views. Highlights
Latest Update (d9c827f)✅ StandardTooltip default delay updated to 600ms, aligning code with PR description for less intrusive tooltips. Minor Observations (Non-blocking)
Status: Approved and ready for merge once draft status is removed. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review Summary
This PR implements excellent improvements to subtask visibility and navigation across history and chat views. The implementation is well-structured, thoroughly tested, and follows existing patterns in the codebase.
Highlights
✅ Clean Architecture: The new useGroupedTasks hook cleanly separates the grouping logic from the UI components, making it reusable and testable.
✅ Comprehensive Tests: All 90 new/modified tests pass, covering the core functionality including:
- Task grouping logic with parent-child relationships
- Expand/collapse behavior preservation
- Search mode flat list with subtask indicators
- Cascade delete with subtask count warnings
- Back-to-parent navigation
✅ Cascade Delete: The deleteTaskWithId function in ClineProvider.ts properly handles recursive subtask deletion, collecting all child IDs before batch deletion.
✅ UI/UX Improvements:
- Circular progress indicator for token usage is a nice visual upgrade
- Back-to-parent navigation improves the subtask experience
- Subtask collapsible rows maintain a clean hierarchy view
✅ i18n: All new strings are properly translated across all 17 locales.
Minor Observations (Non-blocking)
-
Token Progress Indicator: The inline SVG calculation in
TaskHeader.tsx(lines 271-303) could potentially be extracted to a reusable component for cleaner code, though the current implementation works correctly. -
StandardTooltip Delay: The PR description mentions "delay increased to 600ms" but the default in code remains 300ms with a new configurable
delayprop - this is actually better as it provides flexibility while maintaining backward compatibility.
Verified
- All test suites pass (7 files, 90 tests)
- Code follows project conventions and Tailwind CSS usage
- Type safety maintained throughout
Approving this PR - it's ready for merge once the draft status is removed.
|
@roomote implement these improvements: |
- Created reusable CircularProgress component for displaying percentage as a ring - Moved inline SVG calculation from TaskHeader.tsx to dedicated component - Added comprehensive tests for CircularProgress component (14 tests) - Component supports customizable size, strokeWidth, and className - Includes proper accessibility attributes (progressbar role, aria-valuenow)
Reviewing your PR now. I'll share feedback in a few minutes! |
As mentioned in the PR description, increased the tooltip delay to 600ms for less intrusive tooltips. The delay is still configurable via the delay prop for components that need a different value.
Motivation
Subtasks (created via
newTasktool) were not well-represented in the UI, making it difficult for users to:Key Changes
Screenshots
Home
Task Header
Messages
History
History View
TaskGroupItem,SubtaskCollapsibleRow, andSubtaskRowcomponentsuseGroupedTaskshook: Transforms flat task lists into parent-child grouped structure, with flat mode preserved for searchChat View
TaskHeadernow shows a "Back to parent task" button for subtasksChatRowdisplays "Go to subtask" links onnewTasktool messages andsubtask_resultmessagesVisual Polish
StandardTooltipdelay increased to 600ms for less intrusive tooltipsTableUI component for consistent table layoutsi18n
Important
Enhances subtask visibility and navigation in history and chat views with new UI components, hooks, and i18n updates.
TaskGroupItem,SubtaskCollapsibleRow, andSubtaskRowcomponents for collapsible subtask lists.useGroupedTaskshook to transform flat task lists into parent-child structures.TaskHeadernow includes a "Back to parent task" button for subtasks.ChatRowdisplays "Go to subtask" links fornewTaskandsubtask_resultmessages.StandardTooltipdelay increased to 600ms.TableUI component for table layouts.deleteTaskWithIdinClineProvider.tsto handle cascading subtask deletions.This description was created by
for d9c827f. You can customize this summary. It will automatically update as commits are pushed.