-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: warn users when too many MCP tools are enabled #10772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add WarningRow component for displaying generic warnings with icon, title, message, and optional docs link - Add TooManyToolsWarning component that shows when users have more than 40 MCP tools enabled - Add MAX_MCP_TOOLS_THRESHOLD constant (40) - Add i18n translations for the warning message - Integrate warning into ChatView to display after task header - Add comprehensive tests for both components Closes ROO-542
Review complete. No issues found. The new commits successfully move the tool counting logic from frontend to backend, add the warning as a ClineSay message type that persists in task history, and improve i18n with proper pluralization support for all 18 locales. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Review complete. No issues found. The implementation correctly warns users when too many MCP tools are enabled (>40). Backend tool counting logic properly filters disabled/disconnected servers and disabled tools, emits a persistent warning message in task history, and the frontend renders it with proper i18n pluralization support. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Would be nice if there was an easier way for the users to address this, but I can certainly see the argument that awareness is a good first step.
Closes ROO-542.
Summary
MAX_MCP_TOOLS_THRESHOLDto reduce model confusion; export the threshold via shared types and CLI constants for reuse.too_many_tools_warningchat rows from task flow and render a new warning UI using the reusableWarningRowcomponent plus translated copy for tool/server counts.Important
Introduces a warning system for excessive MCP tools to prevent model confusion, with UI updates and tests.
MAX_MCP_TOOLS_THRESHOLDto prevent model confusion.too_many_tools_warningchat rows inTask.tsand renders warning UI usingWarningRow.MAX_MCP_TOOLS_THRESHOLDinconstants.tsandmcp.ts.TooManyToolsWarningandWarningRowcomponents inChatRow.tsx.TooManyToolsWarning.spec.tsxandWarningRow.spec.tsx.This description was created by
for 18bcd22. You can customize this summary. It will automatically update as commits are pushed.