-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: make sidebar width adjustable in task view #10635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review complete. Found 2 issues that need attention:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| {/* Add todo list to sidebar if available */} | ||
| {latestTodos && latestTodos.length > 0 && ( | ||
| <div className="px-3 mt-3"> | ||
| <TodoListDisplay todos={latestTodos} /> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This TodoListDisplay duplicates the one already rendered inside TaskHeader (line 411 of TaskHeader.tsx). When hasTodos is true, TaskHeader shows the todo list at the bottom of the task card, so adding it here results in two identical todo lists in the left panel. Either remove this block or remove the todo display from TaskHeader if the intent is to show todos separately.
Fix it with Roo Code or mention @roomote and request a fix.
| </div> | ||
|
|
||
| {/* Right Panel */} | ||
| <div style={{ width: `${rightWidth}%` }} className="overflow-hidden"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The right panel wrapper needs flex flex-col for the grow class on the Virtuoso container (in ChatView.tsx) to work correctly. Without a flex parent, the chat messages area won't expand to fill the available height.
| <div style={{ width: `${rightWidth}%` }} className="overflow-hidden"> | |
| <div style={{ width: `${rightWidth}%` }} className="overflow-hidden flex flex-col"> |
Fix it with Roo Code or mention @roomote and request a fix.
Implements adjustable sidebar width with drag handle and localStorage persistence
View task on Roo Code Cloud
Important
Introduces adjustable sidebar width in
ChatViewusingResizablePanels, with drag handle andlocalStoragepersistence.ChatView.tsxusingResizablePanels.localStorage.ResizablePanelscomponent inResizablePanels.tsx.ResizablePanelshandles left and right panel widths, with defaults and constraints.localStorageundertask-view-sidebar-width.This description was created by
for 8b37ea7. You can customize this summary. It will automatically update as commits are pushed.