-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Basic settings search #10619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic settings search #10619
Conversation
All issues have been resolved. The code cleanly handles Escape key interactions and the search index registration approach has been refactored to use context-based registration. Latest test fixes add necessary mocks for the new search components.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
The search functionality implementation looks good overall. One cleanup item remains.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
d7bab8c to
0e012f7
Compare
All issues have been resolved. The code cleanly handles Escape key interactions and the search index registration approach has been refactored to use context-based registration. Latest test fixes add necessary mocks for the new search components.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Important
Add searchable settings feature with
SearchableSettingcomponent, search input, and result highlighting in the webview UI.SearchableSettingcomponent to wrap settings elements for search indexing.SettingsSearchcomponent with input and results highlighting.SettingsViewwith tab navigation and result highlighting.About.tsx,AutoApproveSettings.tsx,BrowserSettings.tsx,CheckpointSettings.tsx,ContextManagementSettings.tsx,ExperimentalSettings.tsx,LanguageSettings.tsx,NotificationSettings.tsx,PromptsSettings.tsx,SlashCommandsSettings.tsx,TerminalSettings.tsx,UISettings.tsxwithSearchableSetting.settings-highlight-fadeanimation inindex.cssfor search result highlighting.SettingsView.spec.tsxandSettingsView.change-detection.spec.tsxto accommodate new search functionality.This description was created by
for 0e012f7. You can customize this summary. It will automatically update as commits are pushed.