Open
Conversation
PRD-2163 - Update clerk version
…methods PRD-2164 - Improve SignUp and SignIn logic
…uthWithIdentifier
…in-hooks PRD-2165 - Fix loading state in useAuthWithIdentifier hook
…ith identifier type parameter
PRD - 2166 - Update password hook
…er identifier management and verification flow
…method signature inheritance from useAddIdentifier
PRD-2167 - Update identificator hook
…proved type definitions
…improve type safety for reset strategies
PRD-2186 - Update reset password hook
veliseev93
commented
Feb 11, 2026
| try { | ||
| await signIn?.create({ | ||
| strategy, | ||
| const attempt = await signIn?.create({ |
Collaborator
Author
There was a problem hiding this comment.
It seems like we are trying to log in here, shouldn't we call this method instead:
await signIn?.create({
strategy: strategy,
identifier: email,
});
Collaborator
There was a problem hiding this comment.
@veliseev93 You're right! As discussed, I removed the unnecessary code and simplified the sending logic. Please take a look.
…ecks and streamlining the sign-in process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.