Skip to content

PRD-2157: modal close button on scroll behavior fix#37

Merged
veliseev93 merged 3 commits intodevelopmentfrom
PRD-2157-modal-close-button-behavior-fix
Jan 23, 2026
Merged

PRD-2157: modal close button on scroll behavior fix#37
veliseev93 merged 3 commits intodevelopmentfrom
PRD-2157-modal-close-button-behavior-fix

Conversation

@Tomass673
Copy link
Collaborator

@Tomass673 Tomass673 self-assigned this Jan 22, 2026
@Tomass673 Tomass673 changed the base branch from main to development January 22, 2026 14:46
@Tomass673
Copy link
Collaborator Author

Tomass673 commented Jan 22, 2026

Decided to use different Pressable depending on platform. When you use Pressable from react-native-gesture-handler on iOS + react-native-modal - everything works perfectly fine. But Android + Pressable from react-native-gesture-handler + react-native-modal case - user can't actually press the button. When you use Pressable from react-native on Android + react-native-modal - everything works fine. But iOS + Pressable from react-native + react-native-modal case - while content is scrolling user can't press the button(original bug from task is happening)

@Tomass673 Tomass673 requested a review from veliseev93 January 22, 2026 19:49
@Tomass673 Tomass673 assigned veliseev93 and unassigned Tomass673 Jan 22, 2026
@veliseev93 veliseev93 merged commit 23bc296 into development Jan 23, 2026
1 check passed
@veliseev93 veliseev93 deleted the PRD-2157-modal-close-button-behavior-fix branch January 23, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants