Skip to content

PRD-2152: CodeBlock background color fix#35

Merged
veliseev93 merged 4 commits intodevelopmentfrom
PRD-2152-incorrect-chat-block-color-fix
Jan 26, 2026
Merged

PRD-2152: CodeBlock background color fix#35
veliseev93 merged 4 commits intodevelopmentfrom
PRD-2152-incorrect-chat-block-color-fix

Conversation

@Tomass673
Copy link
Collaborator

@Tomass673 Tomass673 self-assigned this Jan 16, 2026
@Tomass673
Copy link
Collaborator Author

Also, to prevent "React keys must be passed directly to JSX without using spread" error I removed spread ...restProps from AppMarkdownView

@Tomass673 Tomass673 requested a review from veliseev93 January 18, 2026 16:47
@Tomass673 Tomass673 assigned veliseev93 and unassigned Tomass673 Jan 18, 2026
onCitationPress,
isContentReady,
textColor: elementTextColor,
...restProps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to break the chat UI:
Screenshot 2026-01-19 at 08 39 42

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@veliseev93 veliseev93 assigned Tomass673 and unassigned veliseev93 Jan 19, 2026
@Tomass673 Tomass673 assigned veliseev93 and unassigned Tomass673 Jan 23, 2026
@veliseev93
Copy link
Contributor

@Tomass673 Could you please check if maybe we just need to specify the background color in the CodeBlock component on line 59 to solve this problem?

  if (!sourceInfo || sourceInfo === 'markdown') {
    const formattedContent = content.endsWith('\n') ? content.slice(0, -1) : content;

    return (
      <View className='gap-4'>
        {copyButton}
        <AppText style={[fenceStyle, { backgroundColor: isDarkColorScheme ? dark_color : light_color }]}>{formattedContent}</AppText>
      </View>
    );
  }

@veliseev93 veliseev93 assigned Tomass673 and unassigned veliseev93 Jan 26, 2026
@veliseev93 veliseev93 merged commit d65d74b into development Jan 26, 2026
1 check passed
@veliseev93 veliseev93 deleted the PRD-2152-incorrect-chat-block-color-fix branch January 26, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants