Skip to content

Fix SeekableZstdFile write table on on 32bits architecture #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rogdham merged 1 commit into from
Dec 13, 2025
Merged

Fix SeekableZstdFile write table on on 32bits architecture #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to this project will be documented in this file.

## Unreleased

- Fix `SeekableZstdFile` write table entries on 32-bits architectures when there is a huge number of entries

## 0.19.0 (November 7, 2025)

- The project has been completely refactored to use the Zstandard implementation from the standard library ([PEP-784](https://peps.python.org/pep-0784/))
Expand Down
5 changes: 3 additions & 2 deletions src/pyzstd/_seekable_zstdfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,9 @@ def write_seek_table(self, fp: BinaryIO) -> None:
self._s_2uint32.pack_into(ba, offset, 0x184D2A5E, size - 8)
offset += 8
# Entries
for i in range(0, len(self._frames), 2):
self._s_2uint32.pack_into(ba, offset, self._frames[i], self._frames[i + 1])
iter_frames = iter(self._frames)
for frame_c, frame_d in zip(iter_frames, iter_frames, strict=True):
self._s_2uint32.pack_into(ba, offset, frame_c, frame_d)
offset += 8
# Footer
self._s_footer.pack_into(ba, offset, self._frames_count, 0, 0x8F92EAB1)
Expand Down