Skip failed test on 32bit platform #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qykth-git
force-pushed
the
32bit-build
branch
from
2715b72 to
93d4bf6
Compare
qykth-git
changed the title
======================================================================
ERROR: test_write_table (tests.test_seekable.SeekTableCase.test_write_table)
----------------------------------------------------------------------
Traceback (most recent call last):
File ".../tests/test_seekable.py", line 555, in test_write_table
t.write_seek_table(BytesIO())
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
File ".../pyzstd/_seekable_zstdfile.py", line 308, in write_seek_table
for i in range(0, len(self._frames), 2):
~~~^^^^^^^^^^^^^^
OverflowError: cannot fit 'int' into an index-sized integer
----------------------------------------------------------------------
qykth-git
force-pushed
the
32bit-build
branch
from
93d4bf6 to
aa9a0e3
Compare
Owner
|
Hello @qykth-git and thank you for the PR! This issue is completely my bad, I removed the Instead of skipping the test, I tried to patch the crashing code in #62. Could you give it a try? |
Author
|
@Rogdham |
Owner
|
Thank you for checking it out! |
Owner
|
Version 0.19.1 ships the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
write_tabletest in 32 bit build.