-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: migrate react-native-platform-touchable to RNGH #6997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
b59224f
Use RectButton
Rohit3523 3804451
Remove background
Rohit3523 b384537
Snapshot update
Rohit3523 cfe277d
Snapshot fix
Rohit3523 6bac934
chore: format code and fix lint issues
Rohit3523 6170b9a
fix: Button test
OtavioStasiak 83134a2
fix: clearInput icon
OtavioStasiak 67a54cc
fix: snapshot test
OtavioStasiak b8acb3d
fix: tests
OtavioStasiak 5befa55
Changes
Rohit3523 65428e7
Snapshot update
Rohit3523 f22cfa0
making coderabbit happy with option a
Rohit3523 03ee825
test update
Rohit3523 31da7ea
Using touch in message user
Rohit3523 3fcfc30
test fix
Rohit3523 8e56a45
Remove hide keyboard
Rohit3523 fbaf7ac
Wrap GestureHandlerRootView in Button
Rohit3523 ec3c332
snapshot update
Rohit3523 451e53c
Test changes
Rohit3523 d8f209e
chore: format code and fix lint issues
Rohit3523 f852592
e2e test fix
Rohit3523 467784c
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 72064f8
using flexShrink to fix ui issue ;-;
Rohit3523 fc83a68
Improvements
Rohit3523 21ec68e
Merge branch 'develop' into maestro-changes
Rohit3523 83f8c02
Added retry logic for maestro api calling
Rohit3523 b0882fb
use macos 14
Rohit3523 a76c24a
Add maestro path in android
Rohit3523 9653ebb
fix api...
Rohit3523 8a972e7
Add maestro in path
Rohit3523 d7eae22
improve
Rohit3523 312cfff
Use hidekeyboard from helper
Rohit3523 d814fb7
Refactor iOS workflow for Maestro installation and setup
Rohit3523 1d575a4
try 16 pro
Rohit3523 8966d77
More fix
Rohit3523 a3d4b2c
Ignore user test fix
Rohit3523 25ce5ea
chore: format code and fix lint issues
Rohit3523 a63daba
possible fix
Rohit3523 7ff31c1
Merge branch 'maestro-changes' of https://github.com/RocketChat/Rocke…
Rohit3523 ede8727
upload everything for ios temp
Rohit3523 94df785
another try to fix it
Rohit3523 9236738
id fix
Rohit3523 fe600b2
Retry step
Rohit3523 1a68c31
Merge branch 'develop' into maestro-changes
Rohit3523 ecf2306
fix
Rohit3523 6afdb77
fix
Rohit3523 5f12139
Remove latin test
Rohit3523 bb8f4a6
chore: format code and fix lint issues
Rohit3523 3918b2f
more changes
Rohit3523 b747b3b
Merge branch 'maestro-changes' of https://github.com/RocketChat/Rocke…
Rohit3523 ca9a38a
store images in ios
Rohit3523 bb62452
Update scripts/create-avd.sh
Rohit3523 38e5b44
Wrap modal content with GestureHandlerRootView
Rohit3523 220f11f
chore: format code and fix lint issues
Rohit3523 77a819f
Merge branch 'develop' into remove-platform-touchable
Rohit3523 0cb8a41
use arrow function
Rohit3523 dbbc6e3
revert change requested by coderabbit
Rohit3523 95dbbf4
Merge branch 'maestro-changes' into remove-platform-touchable
Rohit3523 39668c7
text fix
Rohit3523 c6dab8a
Merge branch 'develop' into remove-platform-touchable
Rohit3523 de0c109
room info test update
Rohit3523 6b227c4
Links are now clickable
Rohit3523 7075245
chore: format code and fix lint issues
Rohit3523 b80a0c4
more changes
Rohit3523 bbe283e
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 2c42dd2
chore: format code and fix lint issues
Rohit3523 49de3ac
rerun
Rohit3523 94d090d
revert
Rohit3523 b6471d0
snapshot update
Rohit3523 f2b597b
remove comment
Rohit3523 1ff189e
type fix
Rohit3523 19d504b
chore: format code and fix lint issues
Rohit3523 78df300
test update
Rohit3523 be143a4
snapshot fix
Rohit3523 a78962f
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 8110e14
using pressable from rn ;-;
Rohit3523 88a5bd1
snapshot update
Rohit3523 2120cc4
android touchable ripple fix
Rohit3523 0f4d7d7
text fix for ios
Rohit3523 be63388
chore: format code and fix lint issues
Rohit3523 40fdaf3
rerun ci
Rohit3523 aba0a89
revert
Rohit3523 540a96d
code rabbit fix
Rohit3523 2a97280
Added type
Rohit3523 2dbec26
revert change
Rohit3523 12c973d
revert comment
Rohit3523 b21deb5
Merge branch 'develop' into remove-platform-touchable
Rohit3523 4fc639a
revert the suggestion by coderabbit, it open message context instead …
Rohit3523 7e0c888
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,197 @@ | ||
| appId: chat.rocket.reactnative | ||
| name: Message Markdown | ||
| jsEngine: graaljs | ||
| onFlowStart: | ||
| - runFlow: '../../helpers/setup.yaml' | ||
| onFlowComplete: | ||
| - evalScript: ${output.utils.deleteCreatedUsers()} | ||
| tags: | ||
| - test-12 | ||
|
|
||
| --- | ||
| - evalScript: ${output.user = output.utils.createUser()} | ||
|
|
||
| - runFlow: | ||
| file: '../../helpers/login-with-deeplink.yaml' | ||
| env: | ||
| USERNAME: ${output.user.username} | ||
| PASSWORD: ${output.user.password} | ||
| - runFlow: | ||
| file: '../../helpers/search-and-navigate-room.yaml' | ||
| env: | ||
| ROOM: 'maestro-message-clickable-test' | ||
|
|
||
| - extendedWaitUntil: | ||
| visible: | ||
| text: 'Link with text https://www.rocket.chat' | ||
| timeout: 60000 | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '.*detox-public*.' | ||
| timeout: 60000 | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '.*e2e_admin*.' | ||
| timeout: 60000 | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '.*Message with thread*.' | ||
| timeout: 60000 | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'message-thread-button-message with thread' | ||
| timeout: 60000 | ||
|
|
||
| # Tap on detox-public mention to open room info | ||
| - tapOn: | ||
| text: '.*detox-public*.' | ||
|
|
||
| # Verify room info view is shown | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-info-view' | ||
| timeout: 60000 | ||
|
|
||
| # Verify room name is visible in room info | ||
| - assertVisible: | ||
| text: '.*detox-public.*' | ||
|
|
||
| # Go back to room | ||
| - tapOn: | ||
| id: custom-header-back | ||
|
|
||
| # Wait for room view to be visible again | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-maestro-message-clickable-test' | ||
| timeout: 60000 | ||
|
|
||
| # Tap on the URL link to open alert | ||
| - runFlow: | ||
| when: | ||
| platform: Android | ||
| commands: | ||
| - tapOn: | ||
| text: '.*https://www.rocket.chat.*' | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - tapOn: | ||
| point: 66%,66% | ||
|
|
||
| # Verify alert is shown with the link | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '.*Link Pressed*.' | ||
| timeout: 10000 | ||
|
|
||
| - assertVisible: | ||
| text: '.*https://www.rocket.chat*.' | ||
|
|
||
| # Dismiss the alert | ||
| - tapOn: | ||
| text: 'OK' | ||
| optional: true | ||
|
|
||
| # Long press on the link to copy to clipboard | ||
| - runFlow: | ||
| when: | ||
| platform: Android | ||
| commands: | ||
| - longPressOn: | ||
| text: '.*https://www.rocket.chat.*' | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - longPressOn: | ||
| point: 66%,66% | ||
|
|
||
| # Verify clipboard has the link alert | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '.*Link Long Pressed*.' | ||
| timeout: 10000 | ||
|
|
||
| - assertVisible: | ||
| text: '.*https://www.rocket.chat*.' | ||
|
|
||
| # Dismiss the alert | ||
| - tapOn: | ||
| text: 'OK' | ||
| optional: true | ||
|
|
||
| # Tap on e2e_admin mention to open user info | ||
| - tapOn: | ||
| text: '.*e2e_admin*.' | ||
|
|
||
| # Verify user info view is shown | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '.*User info*.' | ||
| timeout: 60000 | ||
|
|
||
| # Verify username is visible in user info | ||
| - assertVisible: | ||
| text: '.*e2e_admin.*' | ||
|
|
||
| # Go back to room | ||
| - tapOn: | ||
| id: custom-header-back | ||
|
|
||
| # Wait for room view to be visible again | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-maestro-message-clickable-test' | ||
| timeout: 60000 | ||
|
|
||
| # Tap on message with thread to open thread room | ||
| - tapOn: | ||
| text: '.*Message with thread*.' | ||
|
|
||
| # Verify thread room view is opened with the correct id | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-message with thread' | ||
| timeout: 60000 | ||
|
|
||
| # Go back to main room | ||
| - tapOn: | ||
| id: header-back | ||
|
|
||
| # Wait for room view to be visible again | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-maestro-message-clickable-test' | ||
| timeout: 60000 | ||
|
|
||
| # Tap on "View thread" button | ||
| - tapOn: | ||
| id: 'message-thread-button-message with thread' | ||
|
|
||
| # Verify thread room view is opened | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-message with thread' | ||
| timeout: 60000 | ||
|
|
||
| # Go back to main room | ||
| - tapOn: | ||
| id: header-back | ||
|
|
||
| # Wait for room view to be visible again | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-maestro-message-clickable-test' | ||
| timeout: 60000 | ||
|
|
||
| # Now tap on a message within the thread | ||
| - tapOn: | ||
| text: '.*a message in thread*.' | ||
|
|
||
| # Verify thread room view remains (clicking message in thread stays in thread) | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'room-view-title-message with thread' | ||
| timeout: 60000 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.