Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
b59224f
Use RectButton
Rohit3523 Feb 19, 2026
3804451
Remove background
Rohit3523 Feb 19, 2026
b384537
Snapshot update
Rohit3523 Feb 19, 2026
cfe277d
Snapshot fix
Rohit3523 Feb 19, 2026
6bac934
chore: format code and fix lint issues
Rohit3523 Feb 19, 2026
6170b9a
fix: Button test
OtavioStasiak Feb 19, 2026
83134a2
fix: clearInput icon
OtavioStasiak Feb 20, 2026
67a54cc
fix: snapshot test
OtavioStasiak Feb 20, 2026
b8acb3d
fix: tests
OtavioStasiak Feb 20, 2026
5befa55
Changes
Rohit3523 Feb 20, 2026
65428e7
Snapshot update
Rohit3523 Feb 20, 2026
f22cfa0
making coderabbit happy with option a
Rohit3523 Feb 20, 2026
03ee825
test update
Rohit3523 Feb 20, 2026
31da7ea
Using touch in message user
Rohit3523 Feb 23, 2026
3fcfc30
test fix
Rohit3523 Feb 23, 2026
8e56a45
Remove hide keyboard
Rohit3523 Feb 23, 2026
fbaf7ac
Wrap GestureHandlerRootView in Button
Rohit3523 Feb 23, 2026
ec3c332
snapshot update
Rohit3523 Feb 23, 2026
451e53c
Test changes
Rohit3523 Feb 23, 2026
d8f209e
chore: format code and fix lint issues
Rohit3523 Feb 23, 2026
f852592
e2e test fix
Rohit3523 Feb 23, 2026
467784c
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 Feb 23, 2026
72064f8
using flexShrink to fix ui issue ;-;
Rohit3523 Feb 23, 2026
fc83a68
Improvements
Rohit3523 Feb 23, 2026
21ec68e
Merge branch 'develop' into maestro-changes
Rohit3523 Feb 23, 2026
83f8c02
Added retry logic for maestro api calling
Rohit3523 Feb 23, 2026
b0882fb
use macos 14
Rohit3523 Feb 23, 2026
a76c24a
Add maestro path in android
Rohit3523 Feb 23, 2026
9653ebb
fix api...
Rohit3523 Feb 23, 2026
8a972e7
Add maestro in path
Rohit3523 Feb 23, 2026
d7eae22
improve
Rohit3523 Feb 23, 2026
312cfff
Use hidekeyboard from helper
Rohit3523 Feb 23, 2026
d814fb7
Refactor iOS workflow for Maestro installation and setup
Rohit3523 Feb 24, 2026
1d575a4
try 16 pro
Rohit3523 Feb 24, 2026
8966d77
More fix
Rohit3523 Feb 24, 2026
a3d4b2c
Ignore user test fix
Rohit3523 Feb 24, 2026
25ce5ea
chore: format code and fix lint issues
Rohit3523 Feb 24, 2026
a63daba
possible fix
Rohit3523 Feb 24, 2026
7ff31c1
Merge branch 'maestro-changes' of https://github.com/RocketChat/Rocke…
Rohit3523 Feb 24, 2026
ede8727
upload everything for ios temp
Rohit3523 Feb 25, 2026
94df785
another try to fix it
Rohit3523 Feb 25, 2026
9236738
id fix
Rohit3523 Feb 25, 2026
fe600b2
Retry step
Rohit3523 Feb 25, 2026
1a68c31
Merge branch 'develop' into maestro-changes
Rohit3523 Feb 26, 2026
ecf2306
fix
Rohit3523 Feb 26, 2026
6afdb77
fix
Rohit3523 Feb 26, 2026
5f12139
Remove latin test
Rohit3523 Feb 26, 2026
bb8f4a6
chore: format code and fix lint issues
Rohit3523 Feb 26, 2026
3918b2f
more changes
Rohit3523 Feb 26, 2026
b747b3b
Merge branch 'maestro-changes' of https://github.com/RocketChat/Rocke…
Rohit3523 Feb 26, 2026
ca9a38a
store images in ios
Rohit3523 Feb 26, 2026
bb62452
Update scripts/create-avd.sh
Rohit3523 Feb 26, 2026
38e5b44
Wrap modal content with GestureHandlerRootView
Rohit3523 Feb 26, 2026
220f11f
chore: format code and fix lint issues
Rohit3523 Feb 26, 2026
77a819f
Merge branch 'develop' into remove-platform-touchable
Rohit3523 Feb 26, 2026
0cb8a41
use arrow function
Rohit3523 Feb 27, 2026
dbbc6e3
revert change requested by coderabbit
Rohit3523 Feb 27, 2026
95dbbf4
Merge branch 'maestro-changes' into remove-platform-touchable
Rohit3523 Mar 2, 2026
39668c7
text fix
Rohit3523 Mar 2, 2026
c6dab8a
Merge branch 'develop' into remove-platform-touchable
Rohit3523 Mar 2, 2026
de0c109
room info test update
Rohit3523 Mar 2, 2026
6b227c4
Links are now clickable
Rohit3523 Mar 3, 2026
7075245
chore: format code and fix lint issues
Rohit3523 Mar 3, 2026
b80a0c4
more changes
Rohit3523 Mar 3, 2026
bbe283e
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 Mar 3, 2026
2c42dd2
chore: format code and fix lint issues
Rohit3523 Mar 3, 2026
49de3ac
rerun
Rohit3523 Mar 3, 2026
94d090d
revert
Rohit3523 Mar 3, 2026
b6471d0
snapshot update
Rohit3523 Mar 3, 2026
f2b597b
remove comment
Rohit3523 Mar 4, 2026
1ff189e
type fix
Rohit3523 Mar 4, 2026
19d504b
chore: format code and fix lint issues
Rohit3523 Mar 4, 2026
78df300
test update
Rohit3523 Mar 4, 2026
be143a4
snapshot fix
Rohit3523 Mar 4, 2026
a78962f
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 Mar 4, 2026
8110e14
using pressable from rn ;-;
Rohit3523 Mar 5, 2026
88a5bd1
snapshot update
Rohit3523 Mar 5, 2026
2120cc4
android touchable ripple fix
Rohit3523 Mar 5, 2026
0f4d7d7
text fix for ios
Rohit3523 Mar 5, 2026
be63388
chore: format code and fix lint issues
Rohit3523 Mar 5, 2026
40fdaf3
rerun ci
Rohit3523 Mar 5, 2026
aba0a89
revert
Rohit3523 Mar 5, 2026
540a96d
code rabbit fix
Rohit3523 Mar 5, 2026
2a97280
Added type
Rohit3523 Mar 5, 2026
2dbec26
revert change
Rohit3523 Mar 5, 2026
12c973d
revert comment
Rohit3523 Mar 5, 2026
b21deb5
Merge branch 'develop' into remove-platform-touchable
Rohit3523 Mar 5, 2026
4fc639a
revert the suggestion by coderabbit, it open message context instead …
Rohit3523 Mar 5, 2026
7e0c888
Merge branch 'remove-platform-touchable' of https://github.com/Rocket…
Rohit3523 Mar 5, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .maestro/helpers/send-message.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ tags:
id: message-composer-send
- extendedWaitUntil:
visible:
text: '.*${message}.*'
id: 'message-content-${message}'
timeout: 60000
1 change: 0 additions & 1 deletion .maestro/tests/assorted/profile.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ tags:
# submit button should be disabled because of no changes
- assertVisible:
id: 'profile-view-submit'
enabled: false

# should have new password
- scrollUntilVisible:
Expand Down
8 changes: 5 additions & 3 deletions .maestro/tests/e2ee/utils/change-e2ee-key.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ tags:
- tapOn: New password
- inputText: ${output.data.e2eePassword}
- runFlow: '../../../helpers/hide-keyboard.yaml'
- swipe:
direction: DOWN
duration: 100
- scrollUntilVisible:
element:
text: 'Save Changes'
timeout: 60000
centerElement: true
- tapOn: Save Changes
- extendedWaitUntil:
visible:
Expand Down
1 change: 1 addition & 0 deletions .maestro/tests/room/jump-to-message.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ tags:
text: '.*Load newer.*'
direction: DOWN
timeout: 60000
centerElement: true
- tapOn:
text: 'Load newer'
retryTapIfNoChange: true
Expand Down
197 changes: 197 additions & 0 deletions .maestro/tests/room/message-markdown-click.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,197 @@
appId: chat.rocket.reactnative
name: Message Markdown
jsEngine: graaljs
onFlowStart:
- runFlow: '../../helpers/setup.yaml'
onFlowComplete:
- evalScript: ${output.utils.deleteCreatedUsers()}
tags:
- test-12

---
- evalScript: ${output.user = output.utils.createUser()}

- runFlow:
file: '../../helpers/login-with-deeplink.yaml'
env:
USERNAME: ${output.user.username}
PASSWORD: ${output.user.password}
- runFlow:
file: '../../helpers/search-and-navigate-room.yaml'
env:
ROOM: 'maestro-message-clickable-test'

- extendedWaitUntil:
visible:
text: 'Link with text https://www.rocket.chat'
timeout: 60000
- extendedWaitUntil:
visible:
text: '.*detox-public*.'
timeout: 60000
- extendedWaitUntil:
visible:
text: '.*e2e_admin*.'
timeout: 60000
- extendedWaitUntil:
visible:
text: '.*Message with thread*.'
timeout: 60000
Comment thread
Rohit3523 marked this conversation as resolved.
- extendedWaitUntil:
visible:
id: 'message-thread-button-message with thread'
timeout: 60000

# Tap on detox-public mention to open room info
- tapOn:
text: '.*detox-public*.'

# Verify room info view is shown
- extendedWaitUntil:
visible:
id: 'room-info-view'
timeout: 60000

# Verify room name is visible in room info
- assertVisible:
text: '.*detox-public.*'

# Go back to room
- tapOn:
id: custom-header-back

# Wait for room view to be visible again
- extendedWaitUntil:
visible:
id: 'room-view-title-maestro-message-clickable-test'
timeout: 60000

# Tap on the URL link to open alert
- runFlow:
when:
platform: Android
commands:
- tapOn:
text: '.*https://www.rocket.chat.*'
- runFlow:
when:
platform: iOS
commands:
- tapOn:
point: 66%,66%

# Verify alert is shown with the link
- extendedWaitUntil:
visible:
text: '.*Link Pressed*.'
timeout: 10000

- assertVisible:
text: '.*https://www.rocket.chat*.'

# Dismiss the alert
- tapOn:
text: 'OK'
optional: true

# Long press on the link to copy to clipboard
- runFlow:
when:
platform: Android
commands:
- longPressOn:
text: '.*https://www.rocket.chat.*'
- runFlow:
when:
platform: iOS
commands:
- longPressOn:
point: 66%,66%

# Verify clipboard has the link alert
- extendedWaitUntil:
visible:
text: '.*Link Long Pressed*.'
timeout: 10000

- assertVisible:
text: '.*https://www.rocket.chat*.'

# Dismiss the alert
- tapOn:
text: 'OK'
optional: true

# Tap on e2e_admin mention to open user info
- tapOn:
text: '.*e2e_admin*.'

# Verify user info view is shown
- extendedWaitUntil:
visible:
text: '.*User info*.'
timeout: 60000

# Verify username is visible in user info
- assertVisible:
text: '.*e2e_admin.*'

# Go back to room
- tapOn:
id: custom-header-back

# Wait for room view to be visible again
- extendedWaitUntil:
visible:
id: 'room-view-title-maestro-message-clickable-test'
timeout: 60000

# Tap on message with thread to open thread room
- tapOn:
text: '.*Message with thread*.'

# Verify thread room view is opened with the correct id
- extendedWaitUntil:
visible:
id: 'room-view-title-message with thread'
timeout: 60000

# Go back to main room
- tapOn:
id: header-back

# Wait for room view to be visible again
- extendedWaitUntil:
visible:
id: 'room-view-title-maestro-message-clickable-test'
timeout: 60000

# Tap on "View thread" button
- tapOn:
id: 'message-thread-button-message with thread'

# Verify thread room view is opened
- extendedWaitUntil:
visible:
id: 'room-view-title-message with thread'
timeout: 60000

# Go back to main room
- tapOn:
id: header-back

# Wait for room view to be visible again
- extendedWaitUntil:
visible:
id: 'room-view-title-maestro-message-clickable-test'
timeout: 60000

# Now tap on a message within the thread
- tapOn:
text: '.*a message in thread*.'

# Verify thread room view remains (clicking message in thread stays in thread)
- extendedWaitUntil:
visible:
id: 'room-view-title-message with thread'
timeout: 60000
10 changes: 9 additions & 1 deletion .maestro/tests/room/room-info.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ tags:
env:
id: 'room-info-edit-view-name'
- inputText: ${output.newroomname}
- pressKey: Enter
- runFlow: '../../helpers/hide-keyboard.yaml'
- scrollUntilVisible:
element:
id: 'room-info-edit-view-submit'
Expand Down Expand Up @@ -321,6 +321,14 @@ tags:
timeout: 60000

# should change room description, topic, announcement
- runFlow:
when:
platform: iOS
commands:
- extendedWaitUntil:
notVisible:
text: '.*Settings succesfully changed.*'
timeout: 60000
- scrollUntilVisible:
element:
id: 'room-info-edit-view-topic'
Expand Down
1 change: 0 additions & 1 deletion .maestro/tests/room/room.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ tags:
- tapOn:
id: emoji-searchbar-input
- inputText: 'laughing'
- runFlow: '../../helpers/hide-keyboard.yaml'
- extendedWaitUntil:
visible:
id: emoji-laughing
Expand Down
1 change: 0 additions & 1 deletion .maestro/tests/room/share-message.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ tags:
- tapOn:
id: 'multi-select-search'
- inputText: ${output.otherUser.username}
- runFlow: '../../helpers/hide-keyboard.yaml'
- extendedWaitUntil:
visible:
id: multi-select-item-${output.otherUser.username.toLowerCase()}
Expand Down
8 changes: 4 additions & 4 deletions .maestro/tests/teams/team.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ tags:
id: create-channel-name
- inputText: ${output.privateRoomName}
- runFlow: '../../helpers/hide-keyboard.yaml'
- extendedWaitUntil:
visible:
id: create-channel-submit
- scrollUntilVisible:
element:
id: 'create-channel-submit'
timeout: 60000
label: should have submit button
centerElement: true
- tapOn:
id: create-channel-submit
- extendedWaitUntil:
Expand Down
6 changes: 3 additions & 3 deletions app/containers/Avatar/Avatar.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React from 'react';
import { View } from 'react-native';
import { Image } from 'expo-image';
import Touchable from 'react-native-platform-touchable';
import { settings as RocketChatSettings } from '@rocket.chat/sdk';

import Emoji from '../markdown/components/emoji/Emoji';
Expand All @@ -10,6 +9,7 @@ import { SubscriptionType } from '../../definitions';
import { type IAvatar } from './interfaces';
import MarkdownContext from '../markdown/contexts/MarkdownContext';
import I18n from '../../i18n';
import Touch from '../Touch';

const Avatar = React.memo(
({
Expand Down Expand Up @@ -97,9 +97,9 @@ const Avatar = React.memo(

if (onPress) {
image = (
<Touchable accessible={accessible} accessibilityLabel={avatarAccessibilityLabel} onPress={onPress}>
<Touch accessible={accessible} accessibilityLabel={avatarAccessibilityLabel} onPress={onPress}>
{image}
</Touchable>
</Touch>
);
}

Expand Down
Loading
Loading