Skip to content

fix: prevent falsy values from being coerced to null #6984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yaddalapalli-Charan-Kumar-Naidu wants to merge 6 commits into
base: develop
Choose a base branch
from
+3 −3
Open

fix: prevent falsy values from being coerced to null #6984

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7016d12
fix: prevent falsy values from being coerced to null
Yaddalapalli-Charan-Kumar-Naidu Feb 13, 2026
b45c729
Merge branch 'develop' into fix/user-preferences-falsy-values
Yaddalapalli-Charan-Kumar-Naidu Feb 18, 2026
ad4c17b
fix: use nullish coalescing operator to simplify preference value ret…
Yaddalapalli-Charan-Kumar-Naidu Feb 18, 2026
b61bf1e
Merge branch 'develop' into fix/user-preferences-falsy-values
Yaddalapalli-Charan-Kumar-Naidu Feb 21, 2026
0d51665
Merge branch 'develop' into fix/user-preferences-falsy-values
Yaddalapalli-Charan-Kumar-Naidu Feb 24, 2026
d0a13d6
Merge branch 'develop' into fix/user-preferences-falsy-values
Yaddalapalli-Charan-Kumar-Naidu Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/lib/methods/userPreferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class UserPreferences {

getString(key: string): string | null {
try {
return this.mmkv.getString(key) || null;
return this.mmkv.getString(key) ?? null;
} catch {
return null;
}
Expand All @@ -110,7 +110,7 @@ class UserPreferences {

getBool(key: string): boolean | null {
try {
return this.mmkv.getBoolean(key) || null;
return this.mmkv.getBoolean(key) ?? null;
} catch {
return null;
}
Expand Down Expand Up @@ -139,7 +139,7 @@ class UserPreferences {

getNumber(key: string): number | null {
try {
return this.mmkv.getNumber(key) || null;
return this.mmkv.getNumber(key) ?? null;
} catch {
return null;
}
Expand Down