-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore(Android): fix CI generated changelog #6922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request refactors the Android changelog preparation workflow by extracting inline truncation logic from a GitHub Action into a dedicated Node.js script that properly handles Unicode grapheme clusters. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
Play Store enforces a 500 character limit for changelogs, but the existing logic was validating against 500 bytes. This allowed multibyte characters to pass the check, causing uploads to fail at release time.
This PR introduces a Node.js script that correctly counts characters and trims the changelog to a maximum of 500 characters, ensuring Play Store uploads succeed reliably.
Action Link: https://github.com/RocketChat/Rocket.Chat.ReactNative/actions/runs/21064075567
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1634
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments