Skip to content

Conversation

@Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Jan 10, 2026

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1664

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Bug Fixes
    • Improved timestamp parsing and formatting consistency to ensure accurate and reliable date display throughout the application.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 10, 2026

Walkthrough

The pull request refactors the Timestamp component to fix timestamp parsing inconsistencies. It introduces timestampMs as a consistent millisecond timestamp derived from value.timestamp, replaces all internal timestamp variable uses with this new variable, and updates the formatDate useMemo and handlePress function dependencies accordingly. No public API changes.

Changes

Cohort / File(s) Summary
Timestamp Parsing & Dependency Management
app/containers/markdown/components/Timestamp.tsx
Added timestampMs variable to parse value.timestamp with radix 10; replaced all internal timestamp references with timestampMs; updated formatDate useMemo dependencies to include value.timestamp, timestampMs, and value.format; updated handlePress dependencies to [timestampMs]

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • diegolmello

Poem

🐰 A timestamp was tangled in parsing despair,
So we parsed it with radix and bundled with care,
Dependencies tidied, and logic made bright,
The message now formats with millisecond might! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The pull request addresses timestamp bug fixes as described in linked issue CORE-1664, with changes that implement memoization and fix timestamp parsing issues across the Timestamp component.
Out of Scope Changes check ✅ Passed All changes in the pull request are scoped to the Timestamp component and directly address the timestamp bug fixes objective, with no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix: timestamp bug fixes' is directly related to the changeset, which addresses timestamp parsing and formatting bugs in the Timestamp component by introducing consistent memoization and proper dependency management.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch timestamp-markdown-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 had a problem deploying to official_android_build January 10, 2026 21:12 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build January 10, 2026 21:12 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build January 10, 2026 21:12 — with GitHub Actions Error
@Rohit3523 Rohit3523 changed the title chore: timestamp bug fixes fix: timestamp bug fixes Jan 12, 2026
@Rohit3523 Rohit3523 requested a deployment to approve_e2e_testing January 16, 2026 07:35 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to experimental_ios_build January 16, 2026 07:39 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to experimental_android_build January 16, 2026 07:39 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to official_android_build January 16, 2026 07:39 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 merged commit ad951f9 into develop Jan 16, 2026
5 of 10 checks passed
@Rohit3523 Rohit3523 deleted the timestamp-markdown-fix branch January 16, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants