Skip to content

Feat/red boundry for empty fields in create reply modal#62

Open
priyanshuharshbodhi1 wants to merge 3 commits intoRocketChat:mainfrom
priyanshuharshbodhi1:feat/red-boundry-for-empty-fields-in-create-reply-modal
Open

Feat/red boundry for empty fields in create reply modal#62
priyanshuharshbodhi1 wants to merge 3 commits intoRocketChat:mainfrom
priyanshuharshbodhi1:feat/red-boundry-for-empty-fields-in-create-reply-modal

Conversation

@priyanshuharshbodhi1
Copy link
Copy Markdown

@priyanshuharshbodhi1 priyanshuharshbodhi1 commented May 2, 2025 •
edited
Loading

Issue(s)

Closes #51

Acceptance Criteria fulfillment

  • Shows error message(below the field) for the corresponding empty field(s) in create modal when user clicks Create Button.

Proposed changes (including videos or screenshots)

Screencast.from.2025-05-02.14-32-01.webm

Further comments

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 2, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@priyanshuharshbodhi1
Copy link
Copy Markdown
Author

priyanshuharshbodhi1 commented May 2, 2025

@VipinDevelops ,
There is no feature in rocket chat uikit to show red boundries to empty fields so I did this as a workaround. Please check into it.

@priyanshuharshbodhi1
Copy link
Copy Markdown
Author

priyanshuharshbodhi1 commented May 2, 2025

Should I implement similarly for other modals? like edit modal...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat] Show red boundary around the empty field when submit btn is clicked.

2 participants

@priyanshuharshbodhi1 @CLAassistant