Add error message for missing attachment description and empty message#58
Open
sushen123 wants to merge 3 commits intoRocketChat:mainfrom
Open
Add error message for missing attachment description and empty message#58sushen123 wants to merge 3 commits intoRocketChat:mainfrom
sushen123 wants to merge 3 commits intoRocketChat:mainfrom
Conversation
iam-vipin
requested changes
Apr 11, 2025
Collaborator
There was a problem hiding this comment.
@sushen123 We define string in differnt langauge when we want to show some text to the user, figure out that and implement that way.
Contributor
Author
Hey i have made the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
#54
Proposed changes (including videos or screenshots)
Here I demonstrate the changes made, showing the error messages displayed when there is no message to reply to, and when an attachment lacks a description.
Screencast.2025-04-01.15.16.18.mp4
Further comments