[FIX] : Filtered out self messages from AI reply generation#44
Open
not-meet wants to merge 1 commit intoRocketChat:mainfrom
Open
[FIX] : Filtered out self messages from AI reply generation#44not-meet wants to merge 1 commit intoRocketChat:mainfrom
not-meet wants to merge 1 commit intoRocketChat:mainfrom
Conversation
Collaborator
|
can you improve the string language and can we do both of this type of handling in a single PR? |
Collaborator
|
@not-meet I'll take care of this in my PR no need for this one also its just duplicated code in this PR nothing new here, You might try doing something better once my pr is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(#40)
Closes #40
Acceptance Criteria fulfillment
What changes i made ?
POC -
Screencast.from.2025-02-27.04-42-14.webm
i have tested out the logic and also checked the error message in all the languages available