[FEAT] : AI reply suggestions command fix#39
Open
not-meet wants to merge 3 commits intoRocketChat:mainfrom
Open
[FEAT] : AI reply suggestions command fix#39not-meet wants to merge 3 commits intoRocketChat:mainfrom
not-meet wants to merge 3 commits intoRocketChat:mainfrom
Conversation
3 tasks
Collaborator
|
this should be top of mine PR right ? |
Contributor
Author
|
hi @VipinDevelops i tried what you wanted (to make a pr on top of yours showing in the main repo of quick replies) I think for me to create a pr on top of yours which shows in the main repo of quick replies , it should be available on the main repo i believe what i did from my side
if possible kindly suggest me a way if you know any way to do so that will be a great help ! |
Collaborator
|
@not-meet This should not be done this way just making things complex. |
Collaborator
|
@not-meet Leave the PR I'll see it myself |
|
@VipinDevelops Can I work on this, I have explained what I want to do in #59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
A Pr made fixing the errors and issue of #37
#18
Acceptance Criteria fulfillment
###Testing and demo
Screencast from 2025-02-24 07-00-38.webm
Note - i found that quick replies do get other users message in a different pattern which is
const roomId = room.id; const roomMessages = await read .getRoomReader() .getMessages(roomId); const lastMessage = roomMessages.pop(); const Message = lastMessage?.text || lastMessage?.attachments?.[0]?.description || '';this and i implemented that as well but in the time where there is no message of other user in the room it took the last message available in the room rather then showing error so i opted for the way i committed which finds the message based on the user name
here is the proof of my raised statement

here you can see both works exactly fine when comes to get other users message but in the case where there is no other user message the above command gets the last message in the room