Skip to content

Conversation

@gonzalocasas
Copy link
Collaborator

@gonzalocasas gonzalocasas commented Jan 16, 2026

There are two changes in this PR, both are peripheral to code:

  • Copyright: I've been informed by the ETH Zurich Data Archive team that the text on the copyright notice was incorrect (it points only to our research lab, but it should be prefixed with "ETH Zurich").
  • Integration tests: the ROS2 integration tests were failing because of a missing parameter on the launch file

This tiny PR corrects that to make it compliant

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke check).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas gonzalocasas requested a review from sea-bass January 16, 2026 14:49
@gonzalocasas
Copy link
Collaborator Author

@sea-bass would you have time to check this? thanks!

Copy link

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sea-bass sea-bass merged commit c4aea85 into main Jan 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants