-
Notifications
You must be signed in to change notification settings - Fork 84
Add support check for content filter feature in subscription #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
minggangw
wants to merge
15
commits into
RobotWebTools:develop
Choose a base branch
from
minggangw:fix-1450
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a201c28
Add support check for content filter feature in subscription
minggangw 73a4aaa
Address comments
minggangw cced547
Address comments
minggangw fdf6746
Address comments
minggangw a76200e
Address comments
minggangw ef17a64
Address comments
minggangw b228f52
Address comments
minggangw 58a8aca
Address comments
minggangw a2bf1b5
Address comments
minggangw 762b259
Address comments
minggangw f9a92d8
CI: fix rolling nightly source order and add colcon
minggangw c439dde
Address comments
minggangw 0c534ae
Address comments
minggangw 1205ac2
Address comments
minggangw a0cc7eb
Address comments
minggangw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preprocessor guard
#if ROS_VERSION > 2505is commented as “Rolling only”, but> 2505will also evaluate true for any future non-Rolling distro IDs (e.g., 2605, 2705, …). This can (a) cause build failures ifrcl_subscription_is_cft_supported()remains Rolling-only, and (b) diverge from the JS runtime guard which only enables the method onDistroId.ROLLING. Consider aligning both sides by guarding on the same threshold (e.g.,ROS_VERSION >= 5000if it’s truly Rolling-only, or updating the JS guard/comment if the API is expected to exist on post-Kilted stable distros too).