Change package prefix to ros- or ros2-#104
Open
baszalmstra wants to merge 1 commit intoRoboStack:masterfrom
Open
Change package prefix to ros- or ros2-#104baszalmstra wants to merge 1 commit intoRoboStack:masterfrom
ros- or ros2-#104baszalmstra wants to merge 1 commit intoRoboStack:masterfrom
Conversation
Tobias-Fischer
approved these changes
Oct 31, 2025
Member
|
Personally I would strongly prefer to also generate the old name, at least for a deprecation period, that from what I understand what was we had consensus on #97 (comment) . I really prefer to avoid breaking all existing robostack examples and existing human and llm knoledge (and I am happy to work on adding that). |
Collaborator
Author
|
Makes sense. But then we let those point to the renamed packages instead of the other way around. |
Member
Yes, sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the behavior discussed in #97. Packages are no longer prefixed with
ros-<distro>-but instead withros-for ROS1 andros2-for ROS2.Closes #97