Fix button placement in minimized in-game windows #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Sounds more reasonable to me as it has less constants floating around. That member function looks easy to implement too: combine |
Returns the full size of the window, even when minimized.
Some windows position their buttons based on GetSize().y, which results in incorrect placement if the window is persisted and minimized. Replace uses of GetSize() with GetFullSize(). Affected windows: * iwBuildings * iwDistribution * iwWares
falbrechtskirchinger
force-pushed
the
fix-buttons
branch
from
bb146d7 to
f320335
Compare
Flamefire
reviewed
Jul 26, 2023
Flamefire
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned, I've discovered a bug introduced in 938f355 #1609. This is a very quick fix. Let me know if you'd prefer to store the full size in
IngameWindowand add aGetFullSize()member function, or maybe a different solution entirely.Commit message follows:
Some windows position their buttons based on GetSize().y, which results in incorrect placement if the window is persisted and minimized. Replace uses of GetSize().y with the full window height.
Affected windows: