use fully-qualified rkcommon::math::rsqrt to avoid overload ambiguity #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly calling rkcommon::math::rsqrt() prevents conflict with the standard rsqrt(double) declared in bits/mathcalls.h, fixing the build error in Quaternion tests. Signed-off-by: Yogesh Tyagi <yogesh.tyagi@intel.com>
johguenther
approved these changes
Aug 25, 2025
Contributor
johguenther
left a comment
johguenther
left a comment
There was a problem hiding this comment.
Thanks for those fixes! Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly calling rkcommon::math::rsqrt() prevents conflict with the standard rsqrt(double) declared in bits/mathcalls.h, fixing the build error in Quaternion tests.