Implement bulk delete #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 5, 2025 00:35
andrebsguedes
approved these changes
Feb 10, 2025
Member
andrebsguedes
left a comment
andrebsguedes
left a comment
There was a problem hiding this comment.
Looks great, some minor comments
src/crud_ops.rs
Outdated
| unsafe impl Send for BulkResponse {} | ||
|
|
||
| impl RawResponse for BulkResponse { | ||
| type Payload = Vec<(Path, String)>; |
Member
There was a problem hiding this comment.
As discussed elsewhere we will fix the ergonomics of this later, but one thing we can do now is defer converting the error to string to set_payload. That way a Rust user of bulk_delete still has an Error to work with.
Suggested change
| type Payload = Vec<(Path, String)>; | |
| type Payload = Vec<(Path, crate::Error)>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.