Open
Conversation
comnik
commented
Feb 25, 2026
Collaborator
Author
There was a problem hiding this comment.
Claude says: the grammar's gnf_column_path rule indexes into a Sequence[String] with $$[0], which requires the sequence/list indexing support added in that file.
minsungc
reviewed
Feb 25, 2026
| @@ -6,9 +6,9 @@ | |||
| ;; Define the EDBs we're going to be referring to. | |||
Contributor
There was a problem hiding this comment.
Can't comment on it, but I'm assuming tests/lqp/snapshot.bin should be removed?
Collaborator
Author
There was a problem hiding this comment.
Oh, nice catch, yes
minsungc
reviewed
Feb 25, 2026
| return builtin.list_sort(result) | ||
|
|
||
|
|
||
|
|
minsungc
reviewed
Feb 25, 2026
| | "[" STRING* "]" | ||
| construct: $$ = $2 | ||
| deconstruct if builtin.length($$) != 1: | ||
| $2: Sequence[String] = $$ |
Contributor
There was a problem hiding this comment.
Is there semantics for when gnf_column_path is a sequence of length 1? Is it something we can explicitly disallow?
minsungc
approved these changes
Feb 25, 2026
Contributor
minsungc
left a comment
minsungc
left a comment
There was a problem hiding this comment.
Quick clarifying question otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RelEDB → EDB, dropping the "Rel" prefix which we've been using to indicate constructs that will go away once we drop Rel support. This is not the case for EDB references.
CSVColumn → GNFColumn, generalizing to make column declarations reusable between CSV and Iceberg data.
GNFColumncan represent nested paths like/:append/:METADATA$KEY.Generalize
Snapshotto support multiple mappings. The snapshot implementation on the engine is more awkward than I had hoped for, and this allows us to at least do it more efficiently.