This repository was archived by the owner on Oct 28, 2025. It is now read-only.
Conversation
vustef
commented
Sep 9, 2025
vustef
commented
Sep 9, 2025
vustef
commented
Sep 24, 2025
Collaborator
Author
vustef
left a comment
vustef
left a comment
There was a problem hiding this comment.
Thanks Gerald, looks good to me, but I can't approve the PR since I'm the official author. Let's also have @andrebsguedes review and approve this.
gbrgr
approved these changes
Sep 26, 2025
gbrgr
added a commit
to RelationalAI/RustyIceberg.jl
that referenced
this pull request
Oct 14, 2025
) Adds support for the async interface provided by iceberg_rust_ffi in RelationalAI/iceberg_rust_ffi#3 --------- Co-authored-by: Gerald Berger <gberger.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an async API to the Julia FFI.
Asynchronous calls are supported by allowing users to pass a condition variable which is notified on events. The PR also refactors the way objects from iceberg-rust are represented in the C-API. In particular, we now provide an
IcebergScanobject which corresponds to aScanin iceberg-rust. Properties like batch size and data file concurrency, etc. can be passed to theIcebergScan.