Skip to content

Conversation

@vustef
Copy link
Collaborator

@vustef vustef commented Dec 24, 2025

2 mechanisms are supported:

  • loading credentials through load_table_credentials API call.
  • loading credentials along table, through load_table_with_credentials call.

Test is added but ignored, since it depends on Polaris catalog, which is not available in this repo. I used to verify manually that things work (having spawned Polaris catalog in a separate shell). Here's what happens with iceberg-rest-fixture instead:

Context:
   status: 400 Bad Request
   headers: {"date": "Fri, 26 Dec 2025 09:48:16 GMT", "content-type": "application/json", "content-length": "145", "server": "Jetty(11.0.26)"}
   json: {"error":{"message":"No route for request: GET v1/namespaces/test_credentials_ns/tables/t1/credentials","type":"BadRequestException","code":400}}

So far, this works for s3 credentials. Azure credentials have this issue: apache#1442.

@vustef vustef requested a review from gbrgr December 24, 2025 13:15
Copy link
Collaborator Author

@vustef vustef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as is, to be able to make progress while people are on holidays. Will accept post-hoc reviews.

}

/// Load vended credentials for a table from the catalog.
pub async fn load_table_credentials(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this should be part of the Catalog trait...

@vustef vustef merged commit 346b704 into main Dec 26, 2025
14 checks passed
@vustef vustef deleted the vs-credentials branch December 26, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant