Implement bulk delete #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrebsguedes
left a comment
andrebsguedes
left a comment
There was a problem hiding this comment.
LGTM! Just some minor considerations
(Will approve once we have merged and released object_store_ffi and updated the version here)
src/RustyObjectStore.jl
Outdated
| c_paths = [Base.cconvert(Cstring, path) for path in paths] | ||
| # Create an array of pointers to the Cstrings | ||
| paths_array = [pointer(c_path) for c_path in c_paths] | ||
| result = GC.@preserve paths c_paths paths_array config response event try |
Member
There was a problem hiding this comment.
Quite a lot of GC.@preserve, I think the c_paths is redundant because Base.cconvert(Cstring, String) is a noop IIRC, but it is better to be safe and leave it as you have here.
Member
There was a problem hiding this comment.
I did some testing and Julia appears to be smart enough to convert Vector{String} to Ptr{Ptr{Cchar}} on the @ccall directly. But I leave it for you to decide whether you trust it or not 😉
Author
There was a problem hiding this comment.
changed it to pass Vector{String} directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.