Tests for SPCS Azure #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrebsguedes
left a comment
andrebsguedes
left a comment
There was a problem hiding this comment.
Looking good, some small comments.
Co-authored-by: André Guedes <andre.guedes@relational.ai>
andrebsguedes
approved these changes
Nov 25, 2024
Member
andrebsguedes
left a comment
andrebsguedes
left a comment
There was a problem hiding this comment.
LGTM! Added one more comment on the url parsing thing but you can take it or leave it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few tests for SPCS Azure, as introduced by object_store_ffi#28