FFI and Julia Bindings for incremental scan changes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrgr
reviewed
Nov 3, 2025
Contributor
gbrgr
left a comment
gbrgr
left a comment
There was a problem hiding this comment.
Thanks Vukasin, just posting a first round of comments
| } | ||
|
|
||
| // Use macros from scan_common for shared functionality | ||
| impl_select_columns!(iceberg_select_columns, IcebergScan); |
Contributor
There was a problem hiding this comment.
In this case, I think it is fine to use macros. However, in general macros should also be sometimes avoided, so we could go instead with traits for the builder + scan, and a generic ScanBase<B: BuilderTrait, S: ScanTrait> variant, if we want to keep it more extensible.
Collaborator
Author
There was a problem hiding this comment.
Ok, agree it's better not to rely on macros in future, thanks for pointing out.
Co-authored-by: Gerald Berger <59661379+gbrgr@users.noreply.github.com>
Co-authored-by: Gerald Berger <59661379+gbrgr@users.noreply.github.com>
Co-authored-by: Gerald Berger <59661379+gbrgr@users.noreply.github.com>
…alAI/RustyIceberg.jl into vs-incremental-ffi-and-bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFI and Julia Bindings for incremental scan changes that were introduced with RelationalAI/iceberg-rust#3.
I refactored the file structures a bit, for both Rust and Julia code. Rust code reuses some common parts through macros, for Julia I didn't bother to do that (mostly afraid of macros and ccall interaction being a rabbit hole with little benefit).
Note that I had to use struct instead of const for
ScanRef, since now with additional type, we have method overloads, which if we useScanRefconst aliases actually use same type, and then become overwrites instead of overloads.There's also a new test data, and new test that exercises positional delete and inserts.