Add display.delve to Standard Library (#4272)

* Add display.delve to Standard Library

This contains definitions for the rich display of relations in
supporting front end UIs, such as notebooks, IDEs, and other interactive
environments.

Currently only the Reactive Notebooks supports switching on the
MIME-type in a relation value, but in the future we'd like the Julia SDK
to be able to, e.g. return the result as a DataFrame or a Tables.jl
table if a relation has the MIME type set to MIME_APPLICATION_TABLE

* Add `display.delve` to default installed libraries for new DBs

* Update ClientSDK tests

  * C# and Java SDKs should now check that the list of installed sources
    is non-empty
  * JavaScript SDK includes alglib in the list of default sources

* Make javascript ClientSDK tests agnostic to number of standard libraries.

Also add instructions to README for how to run the tests

* Fix detect_client_sdk_changed break

* Add simple unit tests of display.delve functions

* Apply suggestions from code review

Co-authored-by: Stefan Pabst <pabsts@users.noreply.github.com>

* fix sdk test: list_source

Co-authored-by: David Zhao <david.zhao@relational.ai>
Co-authored-by: Rob Bearman <robbear@hyperfine.com>
Co-authored-by: Stefan Pabst <pabsts@users.noreply.github.com>

Author: 4 people

README.md

@@ -93,6 +93,15 @@ module: {
 }
 ```
 
+### Running Tests
+
+To run the tests, cd into one of the directories below (e.g. `client`), and then after
+running `npm install` per above, you can run:
+
+```shell
+    npm run test
+```
+
 ## Getting Started
 
 Please follow the [installation](#installation) instruction and execute the following JS code:

client/test/sdk/RelAPIMixin.test.js

@@ -3,7 +3,6 @@ const fs = require('fs').promises;
 const os = require('os');
 import LocalConnection from '../../src/sdk/LocalConnection.js';
 
-const defaultSources = ["intrinsics", "stdlib", "ml"];
 const incrementQuery =
 `
 def insert[:x] = x + 1
@@ -75,13 +74,13 @@ describe('RelAPIMixin', () => {
     const dbname = createUniqueName('db');
     initializeDatabase(dbname);
 
-    it(`listSources for ${dbname} should include the keys [${defaultSources.join()}]`, () => {
+    it(`listSources for ${dbname} should include at least one file`, () => {
       return lc.listSources(dbname).then(res => {
         assert.notStrictEqual(res.result.actions, null);
         assert.notStrictEqual(res.result.actions[0], null);
         assert.notStrictEqual(res.result.actions[0].result, null);
         assert.notStrictEqual(res.result.actions[0].result.sources, null);
-        assert(setsEqual(new Set(res.result.actions[0].result.sources.map(x => x.name)), new Set(defaultSources)));
+        assert.notStrictEqual(res.result.actions[0].result.sources.length, 0);
       });
     }).timeout(60000);
     it(`should install 'def foo = {(1,);(2,);(3,)}' without error into test-1.delve via #installSource`, () => {
@@ -94,9 +93,9 @@ describe('RelAPIMixin', () => {
       return lc.listSources(dbname).then(res => {
         assert.strictEqual(res.error, null);
         assert.strictEqual(res.result.problems.length, 0);
-        assert.strictEqual(res.result.actions[0].result.sources.length, defaultSources.length + 1);
+        assert.notStrictEqual(res.result.actions[0].result.sources.length, 0);
         let match = false;
-        for (let i = 0; i < (defaultSources.length + 1); i++) {
+        for (let i = 0; i < (res.result.actions[0].result.sources.length); i++) {
           if (res.result.actions[0].result.sources[i].name === 'test-1.delve') {
             match = true;
           }
@@ -117,9 +116,16 @@ describe('RelAPIMixin', () => {
         assert.strictEqual(res.result.problems.length, 0);
       });
     }).timeout(60000);
-    it(`should be only ${defaultSources.length} sources installed now`, () => {
+    it(`test-1.delve should no longer be installed`, () => {
       return lc.listSources(dbname).then(res => {
-        assert.strictEqual(res.result.actions[0].result.sources.length, defaultSources.length);
+        assert.notStrictEqual(res.result.actions[0].result.sources.length, 0);
+        let match = false;
+        for (let i = 0; i < (res.result.actions[0].result.sources.length); i++) {
+          if (res.result.actions[0].result.sources[i].name === 'test-1.delve') {
+            match = true;
+          }
+        }
+        assert(!match);
       });
     }).timeout(60000);
   });
@@ -471,9 +477,9 @@ describe('RelAPIMixin', () => {
       return lc.listSources(dbname).then(res => {
         assert.strictEqual(res.error, null);
         assert.strictEqual(res.result.problems.length, 0);
-        assert.strictEqual(res.result.actions[0].result.sources.length, defaultSources.length + 1);
+        assert.notStrictEqual(res.result.actions[0].result.sources.length, 0);
         let match = false;
-        for (let i = 0; i < (defaultSources.length + 1); i++) {
+        for (let i = 0; i < (res.result.actions[0].result.sources.length); i++) {
           if (res.result.actions[0].result.sources[i].name === 'test-1.delve') {
             match = true;
           }
@@ -491,9 +497,9 @@ describe('RelAPIMixin', () => {
       return lc.listSources(uniqueCloneName).then(res => {
         assert.strictEqual(res.error, null);
         assert.strictEqual(res.result.problems.length, 0);
-        assert.strictEqual(res.result.actions[0].result.sources.length, defaultSources.length + 1);
+        assert.notStrictEqual(res.result.actions[0].result.sources.length, 0);
         let match = false;
-        for (let i = 0; i < (defaultSources.length + 1); i++) {
+        for (let i = 0; i < (res.result.actions[0].result.sources.length); i++) {
           if (res.result.actions[0].result.sources[i].name === 'test-1.delve') {
             match = true;
           }
@@ -518,9 +524,9 @@ describe('RelAPIMixin', () => {
       return lc.listSources(uniqueCloneName).then(res => {
         assert.strictEqual(res.error, null);
         assert.strictEqual(res.result.problems.length, 0);
-        assert.strictEqual(res.result.actions[0].result.sources.length, defaultSources.length + 1);
+        assert.notStrictEqual(res.result.actions[0].result.sources.length, 0);
         let match = false;
-        for (let i = 0; i < (defaultSources.length + 1); i++) {
+        for (let i = 0; i < (res.result.actions[0].result.sources.length); i++) {
           if (res.result.actions[0].result.sources[i].name === 'test-1.delve') {
             match = true;
           }